Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/PlayersServiceTests.java (1)

409-410: ⚡ Quick win

Use fake factories for PlayerPatchDTO fixtures in tests.

Please replace direct new PlayerPatchDTO() setup with a test fake factory (e.g., PlayerPatchDTOFakes) to keep fixture creation consistent and reusable.

As per coding guidelines, "Ensure test data uses fake factories (PlayerFakes, PlayerDTOFakes)."

Also applies to: 431-432, 452-452

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/services/PlayersServiceTests.java`
around lines 409 - 410, Replace the inline fixture creation using new
PlayerPatchDTO() in PlayersServiceTests with the shared test fake factory (e.g.,
PlayerPatchDTOFakes); instead of constructing and calling
dto.setFirstName("Updated") directly, call the appropriate factory method on
PlayerPatchDTOFakes to produce a DTO prepopulated or then customize it via the
factory (same change for the other occurrences at lines referenced: the second
dto creation and the third occurrence), ensuring tests use the standard
PlayerFakes/PlayerDTOFakes classes for consistent, reusable fixtures.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/PlayersControllerTests.java (1)

596-716: ⚡ Quick win

Add tests for null body, validation failures, and empty JSON object.

The PR objectives state the controller includes a "null-body guard" and "Bean Validation on PlayerPatchDTO" with JSR-380 constraints. The current PATCH test suite does not exercise:

1. Null request body — the guard mentioned in the PR should reject this with 400 Bad Request.
2. Validation failures — if PlayerPatchDTO has constraints like @Size, @Min, @Max, or @Past that apply when fields are present, invalid values should trigger 422 Unprocessable Entity (similar to the PUT test at line 467).
3. Empty JSON object {} — a valid JSON Merge Patch no-op that should succeed with 204 if the player exists.

Adding these tests will improve branch coverage and ensure the controller's validation and guard logic is properly exercised.

🧪 Suggested test additions

Test 1: Null body

/**
 * Given the request body is null
 * When attempting to patch a player
 * Then response status is 400 Bad Request and service is never called
 */
`@Test`
void givenNullBody_whenPatch_thenReturnsBadRequest()
        throws Exception {
    // Given
    Integer squadNumber = 10;
    MockHttpServletRequestBuilder request = MockMvcRequestBuilders
            .patch(PATH + "/{squadNumber}", squadNumber)
            .contentType(MediaType.APPLICATION_JSON);
    // When
    MockHttpServletResponse response = application
            .perform(request)
            .andReturn()
            .getResponse();
    // Then
    verify(playersServiceMock, never()).patch(anyInt(), any(PlayerPatchDTO.class));
    then(response.getStatus()).isEqualTo(HttpStatus.BAD_REQUEST.value());
}

Test 2: Validation failure (example with invalid @Size constraint)

/**
 * Given the request body contains invalid field data (validation fails)
 * When attempting to patch a player
 * Then response status is 422 Unprocessable Entity and service is never called
 */
`@Test`
void givenInvalidPatchData_whenPatch_thenReturnsUnprocessableEntity()
        throws Exception {
    // Given
    Integer squadNumber = 10;
    PlayerPatchDTO dto = new PlayerPatchDTO();
    dto.setFirstName(""); // Assuming `@Size`(min=1) or similar constraint
    String content = objectMapper.writeValueAsString(dto);
    MockHttpServletRequestBuilder request = MockMvcRequestBuilders
            .patch(PATH + "/{squadNumber}", squadNumber)
            .content(content)
            .contentType(MediaType.APPLICATION_JSON);
    // When
    MockHttpServletResponse response = application
            .perform(request)
            .andReturn()
            .getResponse();
    // Then
    verify(playersServiceMock, never()).patch(anyInt(), any(PlayerPatchDTO.class));
    then(response.getStatus()).isEqualTo(HttpStatus.UNPROCESSABLE_ENTITY.value());
}

Test 3: Empty JSON object (no-op)

/**
 * Given the request body is an empty JSON object (no fields to patch)
 * When attempting to patch a player
 * Then response status is 204 No Content (no-op patch succeeds)
 */
`@Test`
void givenEmptyPatchBody_whenPatch_thenReturnsNoContent()
        throws Exception {
    // Given
    Integer squadNumber = 10;
    PlayerPatchDTO dto = new PlayerPatchDTO(); // All fields null
    String content = objectMapper.writeValueAsString(dto);
    Mockito
            .when(playersServiceMock.patch(squadNumber, dto))
            .thenReturn(true);
    MockHttpServletRequestBuilder request = MockMvcRequestBuilders
            .patch(PATH + "/{squadNumber}", squadNumber)
            .content(content)
            .contentType(MediaType.APPLICATION_JSON);
    // When
    MockHttpServletResponse response = application
            .perform(request)
            .andReturn()
            .getResponse();
    // Then
    verify(playersServiceMock, times(1)).patch(anyInt(), any(PlayerPatchDTO.class));
    then(response.getStatus()).isEqualTo(HttpStatus.NO_CONTENT.value());
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/ar/com/nanotaboada/java/samples/spring/boot/test/controllers/PlayersControllerTests.java`
around lines 596 - 716, Add three unit tests in PlayersControllerTests covering
PATCH null body, validation failure, and empty JSON no-op: (1) implement
givenNullBody_whenPatch_thenReturnsBadRequest that sends a PATCH with no content
to PATH+"/{squadNumber}", asserts playersServiceMock.patch is never called and
response status is 400; (2) implement
givenInvalidPatchData_whenPatch_thenReturnsUnprocessableEntity that posts a
PlayerPatchDTO with an invalid field (e.g., empty firstName assuming `@Size`) and
asserts playersServiceMock.patch is never called and response status is 422; (3)
implement givenEmptyPatchBody_whenPatch_thenReturnsNoContent that posts an
all-null PlayerPatchDTO, stub playersServiceMock.patch(squadNumber, dto) to
return true, verify patch called once, and assert response status is 204; use
objectMapper to serialize DTO, MockMvcRequestBuilders.patch to build requests,
and verify/then assertions consistent with existing tests.